Skip to content

fix(tests): Fix test selection and run unit tests of DAV and user_status #48215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nickvergessen merged 3 commits into from
Sep 23, 2024
Merged

fix(tests): Fix test selection and run unit tests of DAV and user_status #48215

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6ad620f
fix(tests): Fix test selection and run unit tests of DAV and user_status
nickvergessen Sep 19, 2024
2110698
fix(user_status): Fix integration test of user status
nickvergessen Sep 19, 2024
69119eb
test: fix ContactsMigratorTest
miaulalala Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
test: fix ContactsMigratorTest 
Signed-off-by: Anna Larch <[email protected]>
  • Loading branch information
@miaulalala @nickvergessen
miaulalala authored and nickvergessen committed Sep 19, 2024
commit 69119eb13b1479d054aff6f3bd42bbed228bff8a
32 changes: 21 additions & 11 deletions apps/dav/tests/integration/UserMigration/ContactsMigratorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,20 +114,30 @@ public function testImportExportAsset(string $userId, string $filename, string $
$exportMetadata = array_filter(['displayName' => $displayName, 'description' => $description]);

$this->assertEquals($importMetadata, $exportMetadata);
$this->assertEquals(count($importCards), count($exportCards));
$this->assertSameSize($importCards, $exportCards);

for ($i = 0; $i < count($importCards); ++$i) {
$this->assertNotEqualsCanonicalizing(
$this->getPropertiesChangedOnImport($importCards[$i]),
$this->getPropertiesChangedOnImport($exportCards[$i]),
);
$importProperties = [];
$exportProperties = [];
for ($i = 0, $iMax = count($importCards); $i < $iMax; ++$i) {
$importProperties[] = $this->getPropertiesChangedOnImport($importCards[$i]);
$exportProperties[] = $this->getPropertiesChangedOnImport($exportCards[$i]);
}

for ($i = 0; $i < count($importCards); ++$i) {
$this->assertEqualsCanonicalizing(
$this->getProperties($importCards[$i]),
$this->getProperties($exportCards[$i]),
);
$this->assertNotEqualsCanonicalizing(
$importProperties,
$exportProperties,
);

$importProperties = [];
$exportProperties = [];
for ($i = 0, $iMax = count($importCards); $i < $iMax; ++$i) {
$importProperties[] = $this->getProperties($importCards[$i]);
$exportProperties[] = $this->getProperties($exportCards[$i]);
}

$this->assertEqualsCanonicalizing(
$importProperties,
$exportProperties,
);
}
}
Loading