refactor(Storage): Make all parameter types strong types #48494
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
3. to review
provokateurin
requested review from
a team,
Altahrim,
ArtificialOwl and
come-nc
and removed request for
a team
provokateurin
added
the
pending documentation
provokateurin
force-pushed
the
refactor/stream-encryption/typings
branch
from
9b32a61 to
73ca69d
Compare
provokateurin
force-pushed
the
refactor/storage/strong-param-types
branch
from
d7aa284 to
024682b
Compare
provokateurin
force-pushed
the
refactor/stream-encryption/typings
branch
2 times, most recently
from
8aceb68 to
4412b2b
Compare
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
refactor/storage/strong-param-types
branch
from
024682b to
14e6734
Compare
come-nc
approved these changes
Oct 8, 2024
susnux
approved these changes
Oct 8, 2024
provokateurin
removed
the
pending documentation
Merged
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding strong types to the interface method parameters is allowed as long as it previously didn't define strong type.
I also added them to all implementations for completeness and readability (but I don't know if this is even necessary safety wise).
Most of it was actually done through IntelliJ refactoring which was able to add the strong type to the interface and to all implementations at the same time.
Based on #48487 due to necessary fixes for those tests.
Checklist
Signed-off-by: provokateurin [email protected]