[stable29] fix: (CalDav) Delete invitation link when deleting Calendars or Events #49428
+51
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SebastianKrupinski <[email protected]>
backportbot
bot
requested review from
SebastianKrupinski,
st3iny and
tcitworld
as code owners
backportbot
bot
added
bug
3. to review
SebastianKrupinski
approved these changes
Nov 21, 2024
ChristophWurst
approved these changes
Nov 22, 2024
| // delete all links that match object uid's | ||
| $cmd = $this->db->getQueryBuilder(); | ||
| $cmd->delete($this->dbObjectInvitationsTable) | ||
| ->where($cmd->expr()->in('uid', $cmd->createNamedParameter('uids'), IQueryBuilder::PARAM_STR_ARRAY)); |
Member
There was a problem hiding this comment.
I thought one had to use \OCP\DB\QueryBuilder\IQueryBuilder::createParameter for a parameter, and createNamedParameter was to set a value directly.
Fine by me if the current code works
2 tasks
st3iny
requested changes
Nov 22, 2024
| // delete all links that match object uid's | ||
| $cmd = $this->db->getQueryBuilder(); | ||
| $cmd->delete($this->dbObjectInvitationsTable) | ||
| ->where($cmd->expr()->in('uid', $cmd->createNamedParameter('uids'), IQueryBuilder::PARAM_STR_ARRAY)); |
Member
There was a problem hiding this comment.
It should be createParameter() instead. I'm 99% sure.
Contributor
There was a problem hiding this comment.
Interesting, I step through tested this, it executes without any errors, but does not actual do what its supposed to do.
4 tasks
st3iny
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of PR #47832