Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Nov 23, 2024

Summary

I'm sorry, I missed some issues during my code review.

  1. Creating a parameter without a value is done via IQueryBuilder::createParameter().
  2. Fixed a small typo.
  3. Fixed inconsistent and missing types for parameters to improve compatibility with oci.

See also #49428 (comment)

Checklist

And fix a typo: chunck -> chunk

Signed-off-by: Richard Steinmetz <[email protected]>
@st3iny st3iny added bug 3. to review Waiting for reviews feature: caldav Related to CalDAV internals labels Nov 23, 2024
@st3iny st3iny self-assigned this Nov 23, 2024
@st3iny
Copy link
Member Author

st3iny commented Nov 23, 2024

/backport to stable30

@st3iny
Copy link
Member Author

st3iny commented Nov 23, 2024

/backport to stable29

@st3iny
Copy link
Member Author

st3iny commented Nov 23, 2024

/backport to stable28

@SebastianKrupinski
Copy link
Contributor

He, can we cancel the back ports of this? I was just going to adjust the original backports.

@st3iny st3iny force-pushed the fix/invitations-named-parameter branch from 15a2c8e to 739ab5c Compare November 23, 2024 15:55
@st3iny
Copy link
Member Author

st3iny commented Nov 23, 2024

He, can we cancel the back ports of this? I was just going to adjust the original backports.

I'd say no. For consistency it is better to merge the other backports and then backport this PR.

@ChristophWurst ChristophWurst merged commit d948fcb into master Nov 25, 2024
187 checks passed
@ChristophWurst ChristophWurst deleted the fix/invitations-named-parameter branch November 25, 2024 16:58
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug feature: caldav Related to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants