Skip to content

Conversation

@pboguslawski
Copy link
Contributor

Summary

When both skeletondirectory and templatedirectory are set to empty strings in configuration, templates folder creation should be disabled and no Create templates folder option should be present in new folder menu.

Related: #39266
Related: #46455
Author-Change-Id: IB#1156403

Checklist

…nfiguration

When both `skeletondirectory` and `templatedirectory` are set to empty
strings in configuration, templates folder creation should be disabled
and no Create templates folder option should be present
in new folder menu.

Related: nextcloud#39266
Related: nextcloud#46455
Author-Change-Id: IB#1156403
Signed-off-by: Pawel Boguslawski <[email protected]>
@AndyScherzinger AndyScherzinger added enhancement 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Jan 27, 2025
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR, I think the change makes sense, only eslint needs a small adjustment

@AndyScherzinger
Copy link
Member

Also just a small thing, we went for the generic license header recently, so contributor attributions should go into the AUTHORS.md file, see https://docs.nextcloud.com/server/latest/developer_manual/getting_started/coding_standards/index.html#license-headers for details.

@pboguslawski
Copy link
Contributor Author

License header removed. Linting fixed.

@AndyScherzinger
Copy link
Member

perfect, thanks @pboguslawski 🙏 - Looks good to me 👍

By the way, you are a member of the Nextcloud Github organization, so you can also create branches and PRs on this repository. That way all Github actions will get executed. Just mentioning it since several actions are disabled on forks for security reasons.

@AndyScherzinger
Copy link
Member

@pboguslawski I pushed your changes to #50464 so all CI checks can run and close this PR in favor of the local one 👍

@pboguslawski pboguslawski deleted the master-IB#1156403 branch January 27, 2025 18:37
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews enhancement feedback-requested papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants