Hide "Create templates folder" option if templates are disabled #50464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Member
Author
|
/backport to stable31 |
Member
Author
|
Backport added in alignment with @juliusknorr |
Member
Author
|
/compile / |
AndyScherzinger
force-pushed
the
fix/50215/hideCreateTemplateFolder
branch
3 times, most recently
from
c1848f5 to
b0d0547
Compare
…in configuration When both `skeletondirectory` and `templatedirectory` are set to empty strings in configuration, templates folder creation should be disabled and no Create templates folder option should be present in new folder menu. Related: #39266 Related: #46455 Author-Change-Id: IB#1156403 Signed-off-by: Pawel Boguslawski <[email protected]> Signed-off-by: Andy Scherzinger <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
AndyScherzinger
force-pushed
the
fix/50215/hideCreateTemplateFolder
branch
from
b0d0547 to
49529f9
Compare
juliusknorr
approved these changes
Jan 27, 2025
artonge
approved these changes
Jan 27, 2025
Member
Author
|
Thanks for the contribution @pboguslawski 🎉 |
4 tasks
Member
|
I pushed a follow up in #50540 as this was breaking richdocuments tests |
Member
Author
|
Thanks a lot @juliusknorr |
8 tasks
Contributor
|
/backport to stable30 |
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces #50215 (to ruin all CI checks)
When both
skeletondirectoryandtemplatedirectoryare set to empty strings in configuration, templates folder creation should be disabled and no Create templates folder option should be present in new folder menu.Related: #39266
Related: #46455
Author-Change-Id: IB#1156403
Checklist