perf(files): Check node type property instead of instance

[Pytal]

Summary

Switch to faster property check

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[Pytal]

/compile

[susnux]

Have you measured it?
instanceof also is basically just a comparison of the prototype property.

But I agree with this changes also because sometimes if you bundle in a second nc-files library you endup with different prototypes so the instance check will fail.
Meaning to be save here we should not use the instanceof especially when nodes can come from apps.

[szaimen]

🐘