Skip to content

perf(files): Check node type property instead of instance #50553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pytal merged 2 commits into from
Jan 30, 2025
Merged

perf(files): Check node type property instead of instance #50553

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a8d069
perf(files): Check node type property instead of instance
Pytal Jan 29, 2025
ac2a943
chore(assets): Recompile assets
nextcloud-command Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apps/files/src/views/folderTree.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import type { TreeNode } from '../services/FolderTree.ts'

import PQueue from 'p-queue'
import { Folder, Node, View, getNavigation } from '@nextcloud/files'
import { FileType, Folder, Node, View, getNavigation } from '@nextcloud/files'
import { translate as t } from '@nextcloud/l10n'
import { emit, subscribe } from '@nextcloud/event-bus'
import { isSamePath } from '@nextcloud/paths'
Expand Down Expand Up @@ -99,21 +99,21 @@ const removeFolderViewSource = (source: string) => {
}

const onCreateNode = (node: Node) => {
if (!(node instanceof Folder)) {
if (node.type !== FileType.Folder) {
return
}
registerNodeView(node)
}

const onDeleteNode = (node: Node) => {
if (!(node instanceof Folder)) {
if (node.type !== FileType.Folder) {
return
}
removeFolderView(node)
}

const onMoveNode = ({ node, oldSource }) => {
if (!(node instanceof Folder)) {
if (node.type !== FileType.Folder) {
return
}
removeFolderViewSource(oldSource)
Expand Down
4 changes: 2 additions & 2 deletions dist/files-init.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files-init.js.map
View file
Open in desktop

Large diffs are not rendered by default.

Loading