fix: Fix psalm taint errors #50800
Merged
fix: Fix psalm taint errors #50800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Côme Chilliet <[email protected]>
Especially with JSON_HEX_TAG it’s perfectly fine to echo JSON, and we only use it in JSON output anyway. Signed-off-by: Côme Chilliet <[email protected]>
var_export is listed as a taint sink because it may output stuff depending on the parameters. It was not the case here, but we can simply json_encode the result by passing it as context to the logger method rather than using var_export. Signed-off-by: Côme Chilliet <[email protected]>
…admin_audit Same issue as var_export, print_r is listed as sink but it’s not when using return:true. Anyway, using the logger context feature is better. Signed-off-by: Côme Chilliet <[email protected]>
This solves some false-positive psalm taint errors Signed-off-by: Côme Chilliet <[email protected]>
…in psalm taint analysis Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
Signed-off-by: Côme Chilliet <[email protected]>
come-nc
force-pushed
the
fix/fix-psalm-taint-errors
branch
from
1debb5d to
c1c59f9
Compare
come-nc
changed the title
come-nc
added
3. to review
nickvergessen
approved these changes
Feb 17, 2025
susnux
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix issues listed by psalm as taint errors by correctly tagging functions which are escaping or checking input.
Checklist