Skip to content

fix: Fix psalm taint errors #50800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 9 commits into from
Feb 17, 2025
+87 −118
Merged

fix: Fix psalm taint errors #50800

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
579a337
fix: Fix psalm taint error in L10N factory
come-nc Feb 13, 2025
fec865c
chore: Correctly flag json encoding methods as escaping html and quotes
come-nc Feb 17, 2025
85fbd3e
fix: Work around psalm taint false-positive by not using var_export
come-nc Feb 17, 2025
25f3888
fix: Work around false-positive psalm taint error calling print_r in …
come-nc Feb 17, 2025
aac79ba
fix: Move config.php taint trust upstream directly in OC\Config class
come-nc Feb 17, 2025
fa108d5
fix: Correctly tag json encoding in BaseResponse to fix false-positive
come-nc Feb 17, 2025
7c90722
fix: Fix psalm taint false-positive by escaping trusted input
come-nc Feb 17, 2025
640dbd0
fix: Fix false-positive psalm taint errors when outputting plain text
come-nc Feb 17, 2025
c1c59f9
chore: Add missing star in phpdoc comment
come-nc Feb 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: Fix false-positive psalm taint errors when outputting plain text 
Signed-off-by: Côme Chilliet <[email protected]>
  • Loading branch information
@come-nc
come-nc committed Feb 17, 2025
commit 640dbd0b5e38ef603c4edcc646ed7df8117c9963
8 changes: 0 additions & 8 deletions build/psalm-baseline-security.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,6 @@
<code><![CDATA[$sqliteFile]]></code>
</TaintedFile>
</file>
<file src="lib/private/legacy/OC_Template.php">
<TaintedHtml>
<code><![CDATA[$exception->getTraceAsString()]]></code>
</TaintedHtml>
<TaintedTextWithQuotes>
<code><![CDATA[$exception->getTraceAsString()]]></code>
</TaintedTextWithQuotes>
</file>
<file src="lib/public/DB/QueryBuilder/IQueryBuilder.php">
<TaintedSql>
<code><![CDATA[$column]]></code>
Expand Down
12 changes: 10 additions & 2 deletions lib/private/legacy/OC_Template.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,15 @@ public static function printExceptionErrorPage($exception, $statusCode = 503) {
die();
}

private static function printPlainErrorPage(\Throwable $exception, bool $debug = false) {
/**
* @psalm-taint-escape has_quotes
* @psalm-taint-escape html
*/
private static function fakeEscapeForPlainText(string $str): string {
return $str;
}

private static function printPlainErrorPage(\Throwable $exception, bool $debug = false): void {
header('Content-Type: text/plain; charset=utf-8');
print("Internal Server Error\n\n");
print("The server encountered an internal error and was unable to complete your request.\n");
Expand All @@ -323,7 +331,7 @@ private static function printPlainErrorPage(\Throwable $exception, bool $debug =
if ($debug) {
print("\n");
print($exception->getMessage() . ' ' . $exception->getFile() . ' at ' . $exception->getLine() . "\n");
print($exception->getTraceAsString());
print(self::fakeEscapeForPlainText($exception->getTraceAsString()));
}
}
}