Skip to content

fix: Use case insensitive check when validating login name #50989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enjeck merged 3 commits into from
Mar 5, 2025
Merged

fix: Use case insensitive check when validating login name #50989

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6690a28
fix: Use case insensitive check when validating login name
enjeck Feb 24, 2025
a6d6a1f
fix: Improve string comparison
enjeck Feb 25, 2025
32e46a8
fix: use mb_strtolower to convert login name
enjeck Mar 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: use mb_strtolower to convert login name 
Signed-off-by: Cleopatra Enjeck M. <[email protected]>
  • Loading branch information
@enjeck
enjeck committed Mar 5, 2025
commit 32e46a8b3ae2939491949f914f0e6530f7e4157e
2 changes: 1 addition & 1 deletion lib/private/User/Session.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,7 @@ private function validateToken($token, $user = null) {
* Check if login names match
*/
private function validateTokenLoginName(?string $loginName, IToken $token): bool {
if (strcasecmp($token->getLoginName(), $loginName ?? '') !== 0) {
if (mb_strtolower($token->getLoginName()) !== mb_strtolower($loginName ?? '')) {
// TODO: this makes it impossible to use different login names on browser and client
// e.g. login by e-mail '[email protected]' on browser for generating the token will not
// allow to use the client token with the login name 'user'.
Expand Down
Loading