refactor: move version rollback hook to event

[AIlkiv]

• Resolves: #

Summary

I'm working on a fix for the problem nextcloud/collectives#1602. In order not to do it through hooks, I decided to first rewrite the rollback hook to the event.

I also added backwards compatibility.

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[susnux]

In general it is quite nice now!
I would really like if you add a test to VersionManagerTest that checks the event is emitted correctly

[artonge]

Some places in server using that event:

• server/apps/admin_audit/lib/AppInfo/Application.php

  Line 223 in 0771906

  Util::connectHook('\OCP\Versions', 'rollback', $versionsActions, 'rollback');

• server/lib/private/Preview/WatcherConnector.php

  Line 48 in 0771906

  \OC_Hook::connect('\OCP\Versions', 'rollback', $this->getWatcher(), 'versionRollback');

Can you migrate them ?

[come-nc]

You need to apply the codestyle by running composer run cs:fix
See https://github.com/nextcloud/server/actions/runs/13497173837/job/37715071611?pr=50990

[AIlkiv]

@artonge I can try. But it will be a separate PR since I need to allocate additional time to understand that code.

Some places in server using that event:

• server/apps/admin_audit/lib/AppInfo/Application.php

  Line 223 in 0771906

  Util::connectHook('\OCP\Versions', 'rollback', $versionsActions, 'rollback');

• server/lib/private/Preview/WatcherConnector.php

  Line 48 in 0771906

  \OC_Hook::connect('\OCP\Versions', 'rollback', $this->getWatcher(), 'versionRollback');

Can you migrate them ?

[susnux]

I can try. But it will be a separate PR since I need to allocate additional time to understand that code.

Would be nice, and a follow up is perfectly fine :)

[AIlkiv]

@come-nc I fixed the styles. Please run the tests again.

[come-nc]

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

https://github.com/nextcloud/server/actions/runs/13507438734/job/37768873708?pr=50990

[AIlkiv]

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

https://github.com/nextcloud/server/actions/runs/13507438734/job/37768873708?pr=50990

@come-nc done

[AIlkiv]

@come-nc It seems that the failed checks are not related to the current PR.

[susnux]

@sorbaugh cypress unrelated due to fork. Could you please merge?

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)