Skip to content

Conversation

@AIlkiv
Copy link
Contributor

@AIlkiv AIlkiv commented Mar 20, 2025

๐Ÿ“ Summary

Continuation of this PR #6918. In 31 (nextcloud/server#50990), I rewrote the rollback hook to VersionRestoredEvent. This PR removes the hook and adds a listener

๐Ÿ–ผ๏ธ Screenshots

๐Ÿš๏ธ Before ๐Ÿก After
B A

๐Ÿšง TODO

  • ...

๐Ÿ Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for following up on that. CI has a small complaint about code style/psalm and autoloader, but otherwise ๐Ÿ‘

Let me know if you need any help to get those resolved

@AIlkiv AIlkiv force-pushed the chore/update-rollback-handling branch from 2479d87 to f2bba21 Compare April 1, 2025 05:49
@AIlkiv
Copy link
Contributor Author

AIlkiv commented Apr 1, 2025

@juliusknorr fixed, please start the pipeline again

@juliusknorr juliusknorr merged commit 95fc7cf into nextcloud:main Apr 3, 2025
65 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Apr 4, 2025

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants