Skip to content

[stable29] fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage #51386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sorbaugh merged 1 commit into from
Mar 24, 2025
Merged

[stable29] fix(files_external): Stop building path twice when checking if file exists on case insensitive SMB storage #51386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(files_external): Stop building path twice when checking if file e… 
…xists on case insensitive SMB storage

Signed-off-by: provokateurin <[email protected]>
  • Loading branch information
@provokateurin @backportbot
provokateurin authored and backportbot[bot] committed Mar 11, 2025
commit f45c636e496b61422e9a7de1c56c19f8ff00c57a
2 changes: 1 addition & 1 deletion apps/files_external/lib/Lib/Storage/SMB.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -693,7 +693,7 @@ public function file_exists($path) {
// Case sensitive filesystem doesn't matter for root directory
if ($this->caseSensitive === false && $path !== '') {
$filename = basename($path);
$siblings = $this->getDirectoryContent(dirname($this->buildPath($path)));
$siblings = $this->getDirectoryContent(dirname($path));
foreach ($siblings as $sibling) {
if ($sibling['name'] === $filename) {
return true;
Expand Down
Loading