fix(dav): do not require CSRF for safe and indempotent HTTP methods #51457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
artonge,
come-nc,
provokateurin and
sorbaugh
and removed request for
a team and
sorbaugh
| // GET requires no check at all | ||
| if ($this->request->getMethod() === 'GET') { | ||
|
|
||
| $methodsWithoutCsrf = ['GET', 'HEAD', 'OPTIONS']; |
Member
There was a problem hiding this comment.
A HEAD request is turned into a GET request by the web server, so PHP will never see any HEAD requests.
Contributor
There was a problem hiding this comment.
Is that true for all webserver configurations?
come-nc
approved these changes
Mar 13, 2025
artonge
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Safe methods (and idempotent) do not need CSRF protection - especially as HEAD is basically a GET without a body.
Checklist