Skip to content

fix(dav): do not require CSRF for safe and indempotent HTTP methods #51457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 1 commit into from
Mar 17, 2025
Merged

fix(dav): do not require CSRF for safe and indempotent HTTP methods #51457

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions apps/dav/lib/Connector/Sabre/Auth.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,9 @@ public function check(RequestInterface $request, ResponseInterface $response) {
* Checks whether a CSRF check is required on the request
*/
private function requiresCSRFCheck(): bool {
// GET requires no check at all
if ($this->request->getMethod() === 'GET') {

$methodsWithoutCsrf = ['GET', 'HEAD', 'OPTIONS'];
Copy link
Member

@provokateurin provokateurin Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A HEAD request is turned into a GET request by the web server, so PHP will never see any HEAD requests.

Copy link
Contributor

@come-nc come-nc Mar 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that true for all webserver configurations?

if (in_array($this->request->getMethod(), $methodsWithoutCsrf)) {
return false;
}

Expand Down
Loading