Enhancement: Better previews for HDR video

[invario]

• Resolves: #
  [Bug]: Previews of HDR videos being generated are washed out (needs tonemap?) #44881
  Enhance: Better previews for HDR video (CLOSED, IGNORE) #51356 (closed due to a mess I made)

Summary

Picking up where I left off in #51356 where I made a mess of things. Starting over with a clean slate, huge apologies to everyone for the mess in the last PR and thank you for your patience.

Previews currently generated for HDR videos result in desaturated/washed out images because of lack of tonemapping. This enhancement detects HDR videos and adds additional switches to the ffmpeg command to generate much improved images.

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[invario]

@icewind1991 Created a new PR, sorry for the trouble!.

[invario]

Can anyone advise if I need to do anything further here or just be patient? Thank you.

[artonge]

Can you also squash your commit and respect the conventional commit spec in the message? Something like "feat(previews): Use proper colorspace for HDR movies"

And maybe extract part of the logic in methods to make it obvious what they do.

[invario]

Can you also squash your commit and respect the conventional commit spec in the message? Something like "feat(previews): Use proper colorspace for HDR movies"

And maybe extract part of the logic in methods to make it obvious what they do.

Okay, I will attempt to do that; this is quite the learning process for me, so I appreciate all the feedback/direction, thanks!

[artonge]

Much easier to read! thanks @invario ❤️

[come-nc]

A few improvements suggestions.
I did not test the PR.

[invario]

A few improvements suggestions. I did not test the PR.

Thank you, incorporated everything suggested!

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[come-nc]

A few improvements suggestions. I did not test the PR.

Thank you, incorporated everything suggested!

Thank you for your contribution!

If you wish, I can invite you to have a guest account on the developper channel.
Just tell me and I will send the invite to the email you signed off the first commit with.

[invario]

Yes, please. Thank you!

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)