Skip to content

fix(preview): Fix constructor parameter name and default value #52014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
provokateurin merged 2 commits into from
Apr 8, 2025
Merged

fix(preview): Fix constructor parameter name and default value #52014

provokateurin merged 2 commits into from
Apr 8, 2025

Conversation

@come-nc
Copy link
Contributor

@come-nc come-nc commented Apr 8, 2025 •
edited
Loading

This should fix tests for movie preview provider

Summary

  • Fixes OC\Preview\Movie constructor to fix tests.
  • Cleanup its code for deprecated stuff and psalm warnings.

Checklist

@come-nc
fix(preview): Fix constructor parameter name and default value
85934d4 
This should fix tests for movie preview provider

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc added the 2. developing Work in progress label Apr 8, 2025
@come-nc come-nc added this to the Nextcloud 32 milestone Apr 8, 2025
@come-nc come-nc self-assigned this Apr 8, 2025
@come-nc come-nc added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Apr 8, 2025
@come-nc come-nc marked this pull request as ready for review April 8, 2025 07:54
@come-nc come-nc requested a review from a team as a code owner April 8, 2025 07:54
@come-nc come-nc requested review from Altahrim, skjnldsv and sorbaugh and removed request for a team April 8, 2025 07:54
@provokateurin provokateurin merged commit 065a976 into master Apr 8, 2025
212 of 222 checks passed
@provokateurin provokateurin deleted the fix/fix-movie-preview-construct branch April 8, 2025 12:38
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miaulalala miaulalala miaulalala approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@provokateurin provokateurin provokateurin approved these changes

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@come-nc @miaulalala @skjnldsv @provokateurin