fix: Remove support for app.php loading #52178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has been deprecated for a long time, and the last known active application to use it (user_saml) is now migrated the modern API. Presence of the file is still checked in order to log an error. This behavior may be removed as well in a few versions. Signed-off-by: Côme Chilliet <[email protected]>
come-nc
requested review from
ArtificialOwl,
icewind1991 and
provokateurin
and removed request for
a team
Signed-off-by: Côme Chilliet <[email protected]>
Contributor
Author
|
https://github.com/nextcloud/server/actions/runs/14446111109/job/40507234995?pr=52178 user_saml is broken it seems, but not by this PR, most likely by related PR nextcloud/user_saml#611 |
susnux
approved these changes
Apr 14, 2025
susnux
added
technical debt
pending documentation
Contributor
|
remember to not only add to app upgrade guides but also remove this section: |
Member
|
omg yes!! 🙏 |
skjnldsv
approved these changes
Apr 14, 2025
Member
|
Thank you very much!! 🧹 🚀 |
come-nc
removed
the
pending documentation
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It has been deprecated for a long time, and the last known active application to use it (user_saml) is now migrated to the modern API.
Presence of the file is still checked in order to log an error. This behavior may be removed as well in a few versions.
Checklist