Skip to content

Conversation

@CarlSchwan
Copy link
Member

Remove a bunch of deprecated stuff

@CarlSchwan CarlSchwan self-assigned this May 9, 2022
@CarlSchwan CarlSchwan marked this pull request as draft May 9, 2022 10:52
@CarlSchwan CarlSchwan force-pushed the cleanup/app-boostrap branch 3 times, most recently from d741067 to ac67e50 Compare May 9, 2022 11:10
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 91 lines in your changes are missing coverage. Please review.

Comparison is base (b366dfd) 0.00% compared to head (4a74f78) 22.51%.
Report is 181 commits behind head on master.

❗ Current head 4a74f78 differs from pull request most recent head f05f999. Consider uploading reports for the commit f05f999 to get more accurate results

Additional details and impacted files
@@              Coverage Diff              @@
##             master     #611       +/-   ##
=============================================
+ Coverage      0.00%   22.51%   +22.51%     
- Complexity      361      379       +18     
=============================================
  Files            23       22        -1     
  Lines          1704     1426      -278     
=============================================
+ Hits              0      321      +321     
+ Misses         1704     1105      -599     
Files Coverage Δ
lib/UserBackend.php 29.02% <ø> (+29.02%) ⬆️
lib/AppInfo/Application.php 15.00% <1.08%> (+15.00%) ⬆️

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@juliusknorr
Copy link
Member

juliusknorr commented Oct 26, 2023

Just rebased, a few things left

  • Move script handling to event listener
  • Register middleware/service through register method
  • Checkout if other private methods can be replaced
  • registerDavAuth seems unused currently

@juliusknorr juliusknorr force-pushed the cleanup/app-boostrap branch from f05f999 to f733354 Compare August 21, 2024 13:38
@come-nc come-nc linked an issue Apr 10, 2025 that may be closed by this pull request
@come-nc come-nc force-pushed the cleanup/app-boostrap branch from f733354 to bae3750 Compare April 10, 2025 13:53
@come-nc
Copy link
Contributor

come-nc commented Apr 10, 2025

Rebased and integrated commits on app.php since last time the PR was rebased.

@come-nc
Copy link
Contributor

come-nc commented Apr 10, 2025

Should be rebased after:

To fix the psalm issue most likely.

Regarding OC_User, sadly it is necessary, until nextcloud/server#52086 is merged. (But then it will still be necessary here unless you drop support for Nextcloud < 32)

Regarding other deprecated/private methods, I think cleaning that up should be postponed to another PR so that this one can be merged before conflicting again.

CarlSchwan and others added 2 commits April 14, 2025 10:46
Remove a bunch of deprecated stuff

Signed-off-by: Carl Schwan <[email protected]>
@come-nc come-nc force-pushed the cleanup/app-boostrap branch from e6ba7c3 to 1f5516a Compare April 14, 2025 08:52
@come-nc come-nc force-pushed the cleanup/app-boostrap branch from 1f5516a to 3f2ac22 Compare April 14, 2025 09:14
@come-nc come-nc marked this pull request as ready for review April 14, 2025 09:30
@come-nc come-nc requested a review from blizzz April 14, 2025 09:30
@blizzz blizzz merged commit bd489b2 into master Apr 14, 2025
52 checks passed
@blizzz blizzz deleted the cleanup/app-boostrap branch April 14, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate away from app.php

5 participants