refactor(dav): use first class callable syntax to boot the app #52427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
artonge,
come-nc and
nfebe
and removed request for
a team
ChristophWurst
approved these changes
Apr 25, 2025
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Nice!
nit: make the commit a refactor 🤓
st3iny
force-pushed
the
chore/dav/first-class-callable
branch
from
d0944e8 to
628b38a
Compare
4 tasks
st3iny
changed the title
susnux
approved these changes
Apr 25, 2025
Contributor
susnux
left a comment
susnux
left a comment
There was a problem hiding this comment.
also its typed instead of plain strings
ChristophWurst
added
4. to release
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
chore/dav/first-class-callable
branch
from
628b38a to
109422f
Compare
Member
Author
|
Amended and force pushed again to fix stuck CI. No other changes. |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Should be a bit safer and is available since PHP 8.1.
Checklist