refactor(dav): refactor inline event listeners #52428
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
st3iny
requested review from
Altahrim,
skjnldsv and
yemkareems
and removed request for
a team
st3iny
changed the title
| $event->getRemoved() | ||
| ); | ||
|
|
||
| // Here we should recalculate if reminders should be sent to new or old sharees |
Member
There was a problem hiding this comment.
This comment was just moved, but is this an open todo? I don't get it
Member
Author
There was a problem hiding this comment.
I moved it from the (duplicated) inline listener. It is from Thomas initially so I decided to keep it 😅
st3iny
force-pushed
the
chore/dav/first-class-callable
branch
from
d0944e8 to
628b38a
Compare
st3iny
force-pushed
the
chore/dav/refactor-inline-listeners
branch
from
cef4db3 to
692c08f
Compare
st3iny
changed the title
st3iny
force-pushed
the
chore/dav/refactor-inline-listeners
branch
from
692c08f to
ab3f062
Compare
SebastianKrupinski
approved these changes
Apr 25, 2025
ChristophWurst
approved these changes
Apr 25, 2025
st3iny
force-pushed
the
chore/dav/first-class-callable
branch
from
628b38a to
109422f
Compare
Signed-off-by: Richard Steinmetz <[email protected]>
st3iny
force-pushed
the
chore/dav/refactor-inline-listeners
branch
from
ab3f062 to
16dd61c
Compare
st3iny
added
4. to release
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 💌 📅 👥 Groupware team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$backend->onCalendarUpdateShares()(once inline and once in the already existing listener class).Based on #52427
Checklist