Skip to content

fix: don't log error when default contact template does not exist #52493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
st3iny wants to merge 1 commit into from
Closed

fix: don't log error when default contact template does not exist #52493

st3iny wants to merge 1 commit into from

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Apr 28, 2025 •
edited
Loading

Summary

Prevent error log spam.

Checklist

@st3iny st3iny added bug 3. to review Waiting for reviews labels Apr 28, 2025
@st3iny st3iny requested a review from hamza221 April 28, 2025 08:16
@st3iny st3iny self-assigned this Apr 28, 2025
@st3iny st3iny requested a review from a team as a code owner April 28, 2025 08:16
@st3iny st3iny requested review from ArtificialOwl, icewind1991 and provokateurin and removed request for a team April 28, 2025 08:16
@st3iny st3iny mentioned this pull request Apr 28, 2025
Merged
4 tasks
@provokateurin provokateurin enabled auto-merge April 28, 2025 08:32
@st3iny
Copy link
Member Author

st3iny commented Apr 28, 2025

Hamza discovered another bug and this is just the symptom. Let's hold on for a bit.

@st3iny st3iny disabled auto-merge April 28, 2025 08:33
@st3iny st3iny marked this pull request as draft April 28, 2025 08:33
@hamza221 hamza221 mentioned this pull request Apr 28, 2025
Merged
4 tasks
@st3iny
Copy link
Member Author

st3iny commented Apr 28, 2025

Superseded by #52494.

@st3iny st3iny closed this Apr 28, 2025
@st3iny st3iny deleted the fix/default-contact-error-verbosity branch April 28, 2025 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@provokateurin provokateurin provokateurin approved these changes

@hamza221 hamza221 hamza221 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

Assignees

@st3iny st3iny

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@st3iny @juliusknorr @provokateurin @hamza221