Skip to content

fix: check if config is enabled before creating a default contact #52494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
st3iny merged 1 commit into from
Apr 28, 2025
Merged

fix: check if config is enabled before creating a default contact #52494

st3iny merged 1 commit into from
Apr 28, 2025

Conversation

@hamza221
Copy link
Contributor

@hamza221 hamza221 commented Apr 28, 2025 •
edited
Loading

Summary

Check if config is enabled, file existing is not an enough indicator

Checklist

@hamza221 hamza221 added bug 3. to review Waiting for reviews labels Apr 28, 2025
@hamza221 hamza221 requested review from juliusknorr and st3iny April 28, 2025 08:47
@hamza221 hamza221 self-assigned this Apr 28, 2025
@hamza221 hamza221 requested a review from a team as a code owner April 28, 2025 08:47
@hamza221 hamza221 requested review from artonge, nfebe and sorbaugh and removed request for a team April 28, 2025 08:47
@st3iny st3iny mentioned this pull request Apr 28, 2025
Closed
4 tasks
@st3iny st3iny added this to the Nextcloud 32 milestone Apr 28, 2025
@hamza221 hamza221 force-pushed the fix/default-contact branch from 706a423 to c80c656 Compare April 28, 2025 09:25
@hamza221 hamza221 requested a review from st3iny April 28, 2025 09:25
@hamza221 hamza221 force-pushed the fix/default-contact branch from c80c656 to 58ffd9d Compare April 28, 2025 09:46
@st3iny st3iny merged commit 1cb1f39 into master Apr 28, 2025
201 of 208 checks passed
@st3iny st3iny deleted the fix/default-contact branch April 28, 2025 11:22
@st3iny st3iny mentioned this pull request Jul 11, 2025
Closed
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@st3iny st3iny st3iny approved these changes

@provokateurin provokateurin provokateurin approved these changes

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@artonge artonge Awaiting requested review from artonge artonge is a code owner automatically assigned from nextcloud/server-backend

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend

Assignees

@hamza221 hamza221

Labels

3. to review Waiting for reviews bug

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@hamza221 @st3iny @provokateurin @skjnldsv