Skip to content

fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay #52586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kesselb merged 1 commit into from
May 6, 2025
Merged

fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay #52586

kesselb merged 1 commit into from
May 6, 2025

Conversation

@nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 2, 2025 •
edited
Loading

  • Additionally removing the actual sleep when throwing method is used, as it is not adding benefit when it's being aborted with 429 in other cases anyway.
  • Also fixes internal server error that was shown when being throttled on public sharing webdav endpoints
Before After
grafik grafik

Checklist

@nickvergessen
fix(throttler): Remove the sleep from the throttler that throws
7964f33 
The sleep is not adding benefit when it's being aborted with 429
in other cases anyway.

Signed-off-by: Joas Schilling <[email protected]>
@nickvergessen nickvergessen added this to the Nextcloud 32 milestone May 2, 2025
@nickvergessen nickvergessen self-assigned this May 2, 2025
@nickvergessen nickvergessen requested a review from a team as a code owner May 2, 2025 10:09
@nickvergessen nickvergessen requested review from ArtificialOwl, icewind1991, miaulalala and yemkareems and removed request for a team May 2, 2025 10:09
@nickvergessen nickvergessen changed the title fix(throttler): Always use the sleepOrThrowOnMax method fix(throttler): Always use the sleepDelayOrThrowOnMax instead of deprecated sleepDelay May 2, 2025
miaulalala
miaulalala approved these changes May 5, 2025
View reviewed changes
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice

@kesselb kesselb merged commit 1c2b4f2 into master May 6, 2025
192 checks passed
@kesselb kesselb deleted the bugfix/noid/remove-sleep-from-throttler branch May 6, 2025 17:22
@nickvergessen nickvergessen mentioned this pull request May 20, 2025
Merged
4 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kesselb kesselb kesselb approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl is a code owner automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend

@yemkareems yemkareems Awaiting requested review from yemkareems yemkareems is a code owner automatically assigned from nextcloud/server-backend

Assignees

@nickvergessen nickvergessen

Labels

3. to review Waiting for reviews bug feature: files feature: sharing

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

5 participants

@nickvergessen @kesselb @miaulalala @skjnldsv