-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional #52628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional #52628
Conversation
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
|
/backport to stable26 |
65f85db to
82e23da
Compare
…bining VALUE_PASSWORD and FLAG_HIDDEN Signed-off-by: provokateurin <[email protected]>
…ssionCredentials as hidden and optional Signed-off-by: provokateurin <[email protected]>
82e23da to
db5f6a4
Compare
|
Backport bot failing? 🤔 |
|
Yeah it's dead atm, but people are working on it already. If it doesn't work by tomorrow morning I will do the backports myself. I suspect this PR will have conflicts anyway, so manual work will be needed. |
|
/backport to stable31 |
|
The backport to # Switch to the target branch and update it
git checkout stable31
git pull origin stable31
# Create the new backport branch
git checkout -b backport/52628/stable31
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 01d2a9f7 db5f6a4e
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52628/stable31Error: Failed to clone repository: Failed to clone and cache repo: EACCES: permission denied, mkdir '/app/cache/nextcloud/server' Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
|
@skjnldsv Seems like there will only be conflicts, so everything will have to be done manually. |
|
/backport to stable31 |
|
@provokateurin testing the bot anyway :) |
Summary
It was not possible before to make a field a password (in order to censor it in API responses) and also make it hidden so that it doesn't need to be configured in the frontend.
I hope this doesn't break anything, but at least the direction of this should be correct. In case something breaks because the value no longer exists another solution has to be found.
I also found the PHP method
writeParameterInputwhich I first started changing until I realized it was no longer used at all and the logic was moved to the frontend without removing the dead code 🫠Checklist