Skip to content

fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional #52628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 2 commits into from
May 5, 2025
Merged

fix(files_external): Mark password fields for LoginCredentials and SessionCredentials as hidden and optional #52628

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d2a9f
fix(files_external): Convert VALUE_HIDDEN to FLAG_HIDDEN to allow com…
provokateurin May 5, 2025
db5f6a4
fix(files_external): Mark password fields for LoginCredentials and Se…
provokateurin May 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix(files_external): Mark password fields for LoginCredentials and Se… 
…ssionCredentials as hidden and optional

Signed-off-by: provokateurin <[email protected]>
  • Loading branch information
@provokateurin
provokateurin committed May 5, 2025
commit db5f6a4e962a8b6100e93154b97347f138e15dc8
4 changes: 3 additions & 1 deletion apps/files_external/lib/Lib/Auth/Password/LoginCredentials.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ public function __construct(
->setText($l->t('Log-in credentials, save in database'))
->addParameters([
(new DefinitionParameter('password', $l->t('Password')))
->setType(DefinitionParameter::VALUE_PASSWORD),
->setType(DefinitionParameter::VALUE_PASSWORD)
->setFlag(DefinitionParameter::FLAG_HIDDEN)
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
]);

$eventDispatcher->addServiceListener(UserLoggedInEvent::class, StorePasswordListener::class);
Expand Down
4 changes: 3 additions & 1 deletion apps/files_external/lib/Lib/Auth/Password/SessionCredentials.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ public function __construct(
->setText($l->t('Log-in credentials, save in session'))
->addParameters([
(new DefinitionParameter('password', $l->t('Password')))
->setType(DefinitionParameter::VALUE_PASSWORD),
->setType(DefinitionParameter::VALUE_PASSWORD)
->setFlag(DefinitionParameter::FLAG_HIDDEN)
->setFlag(DefinitionParameter::FLAG_OPTIONAL),
]);
}

Expand Down
Loading