feat(CertificateManager): Add option to specify the default certificates bundle path #52749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
requested review from
skjnldsv,
sorbaugh and
yemkareems
and removed request for
a team
13 tasks
Contributor
|
Thanks for taking care! I think that change is a really good initiative. As I mentioned in #32963 a while ago, I think it's weird to have our own certificate management, and it makes the administrator's life harder. I'm aware of the issues we had with certificates, especially when running ancient enterprise Linux distributions with outdated bundles, but those infrastructure issues should not justify reinventing the wheel. Nevertheless, a configuration option to opt-out and rely on the system's default is a great start, and I'd recommend accepting it. |
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
This was referenced Sep 25, 2025
Merged
Merged
provokateurin
commented
Nov 13, 2025
artonge
approved these changes
Nov 14, 2025
6 tasks
provokateurin
force-pushed
the
feat/certificatemanager/default-bundle-path-option
branch
from
cacc724 to
fa270b8
Compare
…tes bundle path Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/certificatemanager/default-bundle-path-option
branch
from
fa270b8 to
0c3a872
Compare
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
Member
Author
|
/backport to stable30 |
AndyScherzinger
deleted the
feat/certificatemanager/default-bundle-path-option
branch
This was referenced Dec 1, 2025
This was referenced Dec 1, 2025
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently it's not possible for admins to reject certificates that are part of the default bundle shipped by Nextcloud.
This option allows specifying the default bundle which in turn allows admins to use the system bundle which they might customize to include self-signed certificates and which might also get faster security updates (without even updating Nextcloud).
Checklist