feat(ldap): Allow to use global default_certificates_bundle_path for ldap
#56866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
szaimen
commented
Dec 5, 2025
szaimen
commented
- Follow-up to feat(CertificateManager): Add option to specify the default certificates bundle path #52749
…r ldap Signed-off-by: Simon L. <[email protected]>
szaimen
changed the title
default_certificates_bundle_path fo…default_certificates_bundle_path for ldap
szaimen
commented
Dec 5, 2025
| $this->ldap->setOption(null, LDAP_OPT_X_TLS_REQUIRE_CERT, LDAP_OPT_X_TLS_DEMAND); | ||
| } | ||
|
|
||
| $defaultCertificatePath = $this->configuration->getSystemValue('default_certificates_bundle_path'); |
Contributor
Author
There was a problem hiding this comment.
How can I retrieve a system value here in this class? Or do I need to retrieve it in a different one and pass it over somehow?
Contributor
Author
There was a problem hiding this comment.
Arthur suggested to load the iconfig here: https://github.com/nextcloud/server/blob/450f788e011daccd56b8866e5a0f2993d6726919/apps/user_ldap/lib/ConnectionFactory.php and pass over the value from there.
provokateurin
requested changes
Dec 5, 2025
| $this->ldap->setOption(null, LDAP_OPT_X_TLS_REQUIRE_CERT, LDAP_OPT_X_TLS_DEMAND); | ||
| } | ||
|
|
||
| $defaultCertificatePath = $this->configuration->getSystemValue('default_certificates_bundle_path'); |
Member
There was a problem hiding this comment.
Use \OCP\ICertificateManager::getAbsoluteBundlePath instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.