Skip to content

Conversation

@provokateurin
Copy link
Member

Summary

Based on #52817

Checklist

@provokateurin provokateurin added this to the Nextcloud 32 milestone May 14, 2025
@provokateurin provokateurin requested review from come-nc and susnux May 14, 2025 13:53
@provokateurin provokateurin added 3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels May 14, 2025
@provokateurin provokateurin requested review from ArtificialOwl and nfebe and removed request for a team May 14, 2025 13:53
@provokateurin provokateurin changed the title ci: Add vendor-bin/rector to dependabot refactor: Extend rector to core/ May 14, 2025
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏

Base automatically changed from chore/deps/rector-2.0 to master May 14, 2025 17:19
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good apart from the psalm complain on user session in lostcontroller.

@provokateurin provokateurin force-pushed the refactor/rector-core branch from 0888bee to de30e5f Compare May 14, 2025 21:57
@provokateurin provokateurin requested a review from come-nc May 14, 2025 21:57
@provokateurin provokateurin enabled auto-merge May 14, 2025 22:08
@provokateurin provokateurin force-pushed the refactor/rector-core branch from de30e5f to f848b65 Compare May 14, 2025 22:10
@provokateurin provokateurin force-pushed the refactor/rector-core branch from f848b65 to 82fb8f8 Compare May 14, 2025 22:17
@provokateurin provokateurin merged commit 8ecadfa into master May 14, 2025
213 of 236 checks passed
@provokateurin provokateurin deleted the refactor/rector-core branch May 14, 2025 23:42
@miaulalala miaulalala mentioned this pull request May 26, 2025
4 tasks
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 33, Nextcloud 32 Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants