fix: broken password reset form #53119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
requested review from
icewind1991 and
provokateurin
and removed request for
a team
miaulalala
force-pushed
the
fix/noid/broken-password-reset-form
branch
from
52852ef to
4129e18
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/noid/broken-password-reset-form
branch
from
4129e18 to
08f869d
Compare
provokateurin
approved these changes
May 27, 2025
Member
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Ouch, I forgot that it can mess with DI so bad 😬
Member
|
I had a look at the entire PR again and luckily this was the only case where it happened. Interestingly the |
SystemKeeper
approved these changes
May 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broke in #52820
From sermo:
{ "reqId": "Y8hD0xfuKQ9AbI9JCiTz", "level": 3, "time": "2025-05-26T15:42:16+00:00", "remoteAddr": "116.202.53.135", "user": "--", "app": "index", "method": "HEAD", "url": "/lostpassword/reset/form/dsjfjkldsfjkdsj/dsjfjkldsfjkdsj", "message": "Could not resolve from!", "userAgent": "Nextcloud Server Crawler", "version": "32.0.0.0", "exception": { "Exception": "OC\\AppFramework\\Utility\\QueryNotFoundException", "Message": "Could not resolve from!", "Code": 0, "Trace": [ { "file": "/var/www/html/lib/private/ServerContainer.php", "line": 154, "function": "query", "class": "OC\\AppFramework\\Utility\\SimpleContainer", "type": "->", "args": [ "from", false ] }, { "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php", "line": 415, "function": "query", "class": "OC\\ServerContainer", "type": "->", "args": [ "from", false ] }, { "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php", "line": 74, "function": "query", "class": "OC\\AppFramework\\DependencyInjection\\DIContainer", "type": "->", "args": [ "from", false ] }, { "function": "OC\\AppFramework\\Utility\\{closure}", "class": "OC\\AppFramework\\Utility\\SimpleContainer", "type": "->", "args": [ "*** sensitive parameters replaced ***" ] }, { "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php", "line": 61, "function": "array_map", "args": [ { "__class__": "Closure" }, [ { "__class__": "ReflectionParameter", "name": "appName" }, { "__class__": "ReflectionParameter", "name": "request" }, { "__class__": "ReflectionParameter", "name": "urlGenerator" }, { "__class__": "ReflectionParameter", "name": "userManager" }, { "__class__": "ReflectionParameter", "name": "defaults" }, "And 11 more entries, set log level to debug to see all entries" ] ] }, { "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php", "line": 106, "function": "buildClass", "class": "OC\\AppFramework\\Utility\\SimpleContainer", "type": "->", "args": [ { "__class__": "ReflectionClass", "name": "OC\\Core\\Controller\\LostController" } ] }, { "file": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php", "line": 124, "function": "resolve", "class": "OC\\AppFramework\\Utility\\SimpleContainer", "type": "->", "args": [ "OC\\Core\\Controller\\LostController" ] }, { "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php", "line": 438, "function": "query", "class": "OC\\AppFramework\\Utility\\SimpleContainer", "type": "->", "args": [ "OC\\Core\\Controller\\LostController" ] }, { "file": "/var/www/html/lib/private/AppFramework/DependencyInjection/DIContainer.php", "line": 412, "function": "queryNoFallback", "class": "OC\\AppFramework\\DependencyInjection\\DIContainer", "type": "->", "args": [ "OC\\Core\\Controller\\LostController" ] }, { "file": "/var/www/html/lib/private/AppFramework/App.php", "line": 140, "function": "query", "class": "OC\\AppFramework\\DependencyInjection\\DIContainer", "type": "->", "args": [ "OC\\Core\\Controller\\LostController" ] }, { "file": "/var/www/html/lib/private/Route/Router.php", "line": 313, "function": "main", "class": "OC\\AppFramework\\App", "type": "::", "args": [ "OC\\Core\\Controller\\LostController", "resetform", { "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer" }, { "token": "f1xLLnCz0Q2jAVZNGE1tP", "userId": "dsjfjkldsfjkdsj", "_route": "core.lost.resetform" } ] }, { "file": "/var/www/html/lib/base.php", "line": 1063, "function": "match", "class": "OC\\Route\\Router", "type": "->", "args": [ "/lostpassword/reset/form/dshflsdhjsdhfshjdf/dsjfjkldsfjkdsj" ] }, { "file": "/var/www/html/index.php", "line": 25, "function": "handleRequest", "class": "OC", "type": "::", "args": [] } ], "File": "/var/www/html/lib/private/AppFramework/Utility/SimpleContainer.php", "Line": 131, "message": "Could not resolve from!", "exception": {}, "CustomMessage": "Could not resolve from!" } }Checklist