Skip to content

fix: recommended apps button test #53047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
susnux merged 3 commits into from
May 28, 2025
Merged

fix: recommended apps button test #53047

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d535c37
fix: recommended apps button test
susnux May 22, 2025
bd9a052
chore(assets): Recompile assets
nextcloud-command May 28, 2025
74deaf4
test: adjust for cypress
susnux May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
fix: recommended apps button test 
Regression of #52703 where the
`>` was added by accident and thus the button has a wrong label
including the rest of the button HTML.

Signed-off-by: Ferdinand Thiessen <[email protected]>
  • Loading branch information
@susnux
susnux committed May 28, 2025
commit d535c377cfbf2f802f02e79ed7dad6e3a14cfcd0
9 changes: 4 additions & 5 deletions core/src/components/setup/RecommendedApps.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,16 @@

<div class="dialog-row">
<NcButton v-if="showInstallButton && !installingApps"
type="tertiary"
role="link"
data-cy-setup-recommended-apps-skip
:href="defaultPageUrl"
data-cy-setup-recommended-apps-skip>
variant="tertiary">
{{ t('core', 'Skip') }}
</NcButton>

<NcButton v-if="showInstallButton"
type="primary"
data-cy-setup-recommended-apps-install
:disabled="installingApps || !isAnyAppSelected"
data-cy-setup-recommended-apps-install>
variant="primary"
@click.stop.prevent="installApps">
{{ installingApps ? t('core', 'Installing apps …') : t('core', 'Install recommended apps') }}
</NcButton>
Expand Down
13 changes: 12 additions & 1 deletion cypress/e2e/core/setup.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,8 +124,19 @@ function sharedSetup() {
cy.location('pathname', { timeout: 10000 })
.should('include', '/core/apps/recommended')

// See the apps setup
cy.get('[data-cy-setup-recommended-apps]')
.should('be.visible')
.within(() => {
cy.findByRole('heading', { name: 'Recommended apps' })
.should('be.visible')
cy.findByRole('link', { name: 'Skip' })
.should('be.visible')
cy.findByRole('button', { name: 'Install recommended apps' })
.should('be.visible')
})

// Skip the setup apps
cy.get('[data-cy-setup-recommended-apps]').should('be.visible')
cy.get('[data-cy-setup-recommended-apps-skip]').click()

// Go to files
Expand Down
Loading