fix(settings): change Mastodon only URI to webfinger

[TechnicalSuwako]

• Resolves: [Bug]: "Faith could not update fediverse (e.g. mastodon)" #53107

Summary

The URI for Mastodon only has been changed to the URI used for all Fediverse servers.
https://{$instance}/api/v1/accounts/lookup?acct={$username}@{$instance} → https://{$instance}.well-known/webfinger?resource=acct:{$username}@{$instance}

TODO

• ...

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[joshtrichards]

Thanks @TechnicalSuwako. This change does seem to make sense.

Can you adjust the commit message to be in conventional format?

Refs:

https://swicg.github.io/activitypub-webfinger/
https://docs.joinmastodon.org/spec/webfinger/

[TechnicalSuwako]

@joshtrichards What does the "traditional format" look like?
I use an automatic translation machine...

[susnux]

Code looks good, thank you.
But please fix the tests

There were 2 errors:

1. Test\Accounts\AccountManagerTest::testSanitizingFediverseServer with data set "valid response" ('@[email protected]', '[email protected]', true, '{"username":"foo"}')
   InvalidArgumentException: fediverse

/home/runner/actions-runner/_work/server/server/lib/private/Accounts/AccountManager.php:767
/home/runner/actions-runner/_work/server/server/lib/private/Accounts/AccountManager.php:810
/home/runner/actions-runner/_work/server/server/tests/lib/Accounts/AccountManagerTest.php:877

2. Test\Accounts\AccountManagerTest::testSanitizingFediverseServer with data set "valid response - no at" ('[email protected]', '[email protected]', true, '{"username":"foo"}')
   InvalidArgumentException: fediverse

/home/runner/actions-runner/_work/server/server/lib/private/Accounts/AccountManager.php:767
/home/runner/actions-runner/_work/server/server/lib/private/Accounts/AccountManager.php:810
/home/runner/actions-runner/_work/server/server/tests/lib/Accounts/AccountManagerTest.php:877

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[provokateurin]

/backport to stable31

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[provokateurin]

/backport to stable30

[backportbot]

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/53109/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick ef0729f2 30fc6800 e4897131

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53109/stable31

Error: Failed to clone repository: Failed to create working tree: error: cannot lock ref 'refs/remotes/origin/master': is at 4dcb282 but expected d3dd428
From https://github.com/nextcloud/server
! d3dd428..4dcb282 master -> origin/master (unable to update local ref)

• [new branch] backport/53814/stable30 -> origin/backport/53814/stable30
• [new branch] backport/53814/stable31 -> origin/backport/53814/stable31
  error: cannot lock ref 'refs/remotes/origin/enh/noid/taskpro-audio-chat': is at af059cb but expected cce12a9
  ! cce12a9...af059cb enh/noid/taskpro-audio-chat -> origin/enh/noid/taskpro-audio-chat (unable to update local ref)
  error: cannot lock ref 'refs/remotes/origin/feat/imailaddressvalidator': is at 46206ff but expected 8aba32b
  ! 8aba32b..46206ff feat/imailaddressvalidator -> origin/feat/imailaddressvalidator (unable to update local ref)
  error: cannot lock ref 'refs/remotes/origin/fix/FileList-render': is at e803366 but expected a74a269
  ! a74a269...e803366 fix/FileList-render -> origin/fix/FileList-render (unable to update local ref)
• [new branch] fix/federatedfilesharing/dialog-callback -> origin/fix/federatedfilesharing/dialog-callback

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.