Skip to content

test(files_sharing): split testCanAccessShare into separate tests and fix for PHPUnit 10 #53255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
provokateurin merged 1 commit into from
Jun 2, 2025
Merged

test(files_sharing): split testCanAccessShare into separate tests and fix for PHPUnit 10 #53255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 81 additions & 36 deletions apps/files_sharing/tests/Controller/ShareAPIControllerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,84 +1542,129 @@ function ($user, $group) {
$this->assertEquals($expected, $result->getData());
}

public function testCanAccessShare(): void {
$share = $this->getMockBuilder(IShare::class)->getMock();
public function testCanAccessShareAsOwner(): void {
$share = $this->createMock(IShare::class);
$share->method('getShareOwner')->willReturn($this->currentUser);
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}

$share = $this->getMockBuilder(IShare::class)->getMock();
public function testCanAccessShareAsSharer(): void {
$share = $this->createMock(IShare::class);
$share->method('getSharedBy')->willReturn($this->currentUser);
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}

$share = $this->getMockBuilder(IShare::class)->getMock();
public function testCanAccessShareAsSharee(): void {
$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_USER);
$share->method('getSharedWith')->willReturn($this->currentUser);
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}

$file = $this->getMockBuilder(File::class)->getMock();
public function testCannotAccessLinkShare(): void {
$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
$share->method('getNodeId')->willReturn(42);

$userFolder = $this->getMockBuilder(Folder::class)->getMock();
$userFolder = $this->createMock(Folder::class);
$this->rootFolder->method('getUserFolder')
->with($this->currentUser)
->willReturn($userFolder);

$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}

/**
* @dataProvider dataCanAccessShareWithPermissions
*/
public function testCanAccessShareWithPermissions(int $permissions, bool $expected): void {
$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_USER);
$share->method('getSharedWith')->willReturn($this->createMock(IUser::class));
$share->method('getNodeId')->willReturn(42);

$file = $this->createMock(File::class);

$userFolder = $this->getMockBuilder(Folder::class)->getMock();
$userFolder->method('getFirstNodeById')
->with($share->getNodeId())
->willReturn($file);
$userFolder->method('getById')
->with($share->getNodeId())
->willReturn([$file]);
$this->rootFolder->method('getUserFolder')
->with($this->currentUser)
->willReturn($userFolder);

$file->method('getPermissions')
->will($this->onConsecutiveCalls(Constants::PERMISSION_SHARE, Constants::PERMISSION_READ));
->willReturn($permissions);

// getPermissions -> share
$share = $this->getMockBuilder(IShare::class)->getMock();
$share->method('getShareType')->willReturn(IShare::TYPE_USER);
$share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
if ($expected) {
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
} else {
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}
}

// getPermissions -> read
$share = $this->getMockBuilder(IShare::class)->getMock();
$share->method('getShareType')->willReturn(IShare::TYPE_USER);
$share->method('getSharedWith')->willReturn($this->getMockBuilder(IUser::class)->getMock());
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
public static function dataCanAccessShareWithPermissions(): array {
return [
[Constants::PERMISSION_SHARE, true],
[Constants::PERMISSION_READ, false],
[Constants::PERMISSION_READ | Constants::PERMISSION_SHARE, true],
];
}

$share = $this->getMockBuilder(IShare::class)->getMock();
/**
* @dataProvider dataCanAccessShareAsGroupMember
*/
public function testCanAccessShareAsGroupMember(string $group, bool $expected): void {
$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
$share->method('getSharedWith')->willReturn('group');
$share->method('getSharedWith')->willReturn($group);
$share->method('getNodeId')->willReturn(42);

$file = $this->createMock(File::class);

$userFolder = $this->createMock(Folder::class);
$userFolder->method('getFirstNodeById')
->with($share->getNodeId())
->willReturn($file);
$userFolder->method('getById')
->with($share->getNodeId())
->willReturn([$file]);
$this->rootFolder->method('getUserFolder')
->with($this->currentUser)
->willReturn($userFolder);

$user = $this->createMock(IUser::class);
$this->userManager->method('get')
->with($this->currentUser)
->willReturn($user);

$group = $this->getMockBuilder(IGroup::class)->getMock();
$group = $this->createMock(IGroup::class);
$group->method('inGroup')->with($user)->willReturn(true);
$group2 = $this->getMockBuilder(IGroup::class)->getMock();
$group2 = $this->createMock(IGroup::class);
$group2->method('inGroup')->with($user)->willReturn(false);

$this->groupManager->method('get')->willReturnMap([
['group', $group],
['group2', $group2],
['groupnull', null],
['group-null', null],
]);
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));

$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
$share->method('getSharedWith')->willReturn('group2');
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));

// null group
$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_GROUP);
$share->method('getSharedWith')->willReturn('groupnull');
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
if ($expected) {
$this->assertTrue($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
} else {
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
}
}

$share = $this->createMock(IShare::class);
$share->method('getShareType')->willReturn(IShare::TYPE_LINK);
$this->assertFalse($this->invokePrivate($this->ocs, 'canAccessShare', [$share]));
public static function dataCanAccessShareAsGroupMember(): array {
return [
['group', true],
['group2', false],
['group-null', false],
];
}

public function dataCanAccessRoomShare() {
Expand Down
Loading