Skip to content

style(core): rely on var(--header-height) #53697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Antreesy merged 2 commits into from
Jun 26, 2025
Merged

style(core): rely on var(--header-height) #53697

Antreesy merged 2 commits into from
Jun 26, 2025

Conversation

@Antreesy
Copy link
Contributor

@Antreesy Antreesy commented Jun 26, 2025

  • Resolves:
    • set content margin to depend on header height variable

Checklist

@Antreesy Antreesy added this to the Nextcloud 32 milestone Jun 26, 2025
@Antreesy Antreesy requested review from DorraJaouad and ShGKme June 26, 2025 11:37
@Antreesy Antreesy self-assigned this Jun 26, 2025
@Antreesy Antreesy requested a review from a team as a code owner June 26, 2025 11:37
@Antreesy Antreesy removed the request for review from a team June 26, 2025 11:37
@Antreesy Antreesy added the bug label Jun 26, 2025
@Antreesy Antreesy requested review from nfebe, skjnldsv and susnux June 26, 2025 11:37
@Antreesy Antreesy added 3. to review Waiting for reviews feature: scss labels Jun 26, 2025
@Antreesy Antreesy mentioned this pull request Jun 26, 2025
Merged
9 tasks
@Antreesy
Copy link
Contributor Author

Antreesy commented Jun 26, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
64c9fb4 
Signed-off-by: nextcloud-command <[email protected]>
@Antreesy Antreesy merged commit d00519d into master Jun 26, 2025
124 checks passed
@ShGKme ShGKme changed the title style(content): rely on var(--header-height) style(core): rely on var(--header-height) Jun 26, 2025
@Antreesy Antreesy deleted the fix/noid/content-header-height branch June 26, 2025 12:43
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
Merged
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@ShGKme ShGKme Awaiting requested review from ShGKme

@nfebe nfebe Awaiting requested review from nfebe nfebe is a code owner automatically assigned from nextcloud/server-frontend

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner automatically assigned from nextcloud/server-frontend

Assignees

@Antreesy Antreesy

Labels

3. to review Waiting for reviews bug feature: scss

Projects

None yet

Milestone

Nextcloud 32

Development

Successfully merging this pull request may close these issues.

6 participants

@Antreesy @susnux @DorraJaouad @skjnldsv @nextcloud-command