Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Jul 23, 2025

Part of #53701

Summary

Vue icons

  • Information.vue - 4 replaced
  • ClipboardText.vue - 1 replaced
  • Wrench.vue - 1 replaced
  • ListBox.vue - 1 replaced
  • Contacts.vue - 1 replaced
  • ChartPie.vue - 1 replaced
  • PlayCircle.vue - 1 replaced
  • Cog.vue - 1 replaced
  • CalendarRange.vue - 2 replaced
  • Email.vue - 1 replaced
  • AccountGroup.vue - 4 replaced
  • AccountPlus.vue - 2 replaced
  • CloudCheckVariant.vue - 1 replaced
  • Key.vue - 1 replaced
  • Palette.vue - 3 replaced
  • CalendarBlank.vue - 2 replaced
  • MapMarker.vue - 1 replaced
  • Filter.vue - 1 replaced
  • Pencil.vue - 8 replaced
  • Eye.vue - 1 replaced
  • Clock.vue - 1 replaced
  • Delete.vue - 5 replaced
  • Lock.vue - 2 replaced
  • MapClock.vue - 1 replaced
  • ViewGrid.vue - 1 replaced
  • Network.vue - 1 replaced
  • Account.vue - 4 replaced
  • LockOpen.vue - 1 replaced
  • Tag.vue - 2 replaced
  • ImageEdit.vue - 1 replaced
  • CheckCircle.vue - 1 replaced
  • Circle.vue - 2 replaced

Svg icons

  • account.svg - 2 replaced
  • pencil.svg - 2 replaced
  • account-group.svg - 2 replaced
  • share-variant.svg - 1 replaced
  • movie.svg - 1 replaced
  • calendar-clock.svg - 1 replaced
  • trash-can.svg - 1 replaced
  • tag-multiple.svg - 2 replaced
  • account-clock.svg - 1 replaced
  • delete.svg - 2 replaced
  • account-plus.svg - 2 replaced
  • message-reply-text.svg - 1 replaced
  • comment-processing.svg - 1 replaced
  • calendar.svg - 1 replaced
  • image.svg - 1 replaced
  • network-off.svg - 1 replaced
  • cloud-upload.svg - 2 replaced
  • alert-circle.svg - 1 replaced
  • home.svg - 1 replaced
  • map-marker.svg - 1 replaced

Javascript icons

  • mdiClipboardFlow - 2 replaced
  • mdiCloud - 2 replaced
  • mdiEyeOff - 2 replaced
  • mdiAccountMultiple - 4 replaced
  • mdiShield - 2 replaced
  • mdiCalendarRange - 3 replaced
  • mdiCog - 12 replaced
  • mdiShieldAccount - 2 replaced
  • mdiFeatureSearch - 3 replaced
  • mdiAccountOff - 2 replaced
  • mdiCircle - 6 replaced
  • mdiAccount - 17 replaced
  • mdiTrashCan - 3 replaced
  • mdiKey - 4 replaced
  • mdiEye - 2 replaced
  • mdiBug - 3 replaced
  • mdiStarCircle - 2 replaced
  • mdiCloudSearch - 2 replaced
  • mdiClock - 2 replaced
  • mdiStarShooting - 4 replaced
  • mdiControllerClassic - 2 replaced
  • mdiArchive - 2 replaced
  • mdiTooltipQuestion - 3 replaced
  • mdiViewColumn - 2 replaced
  • mdiTextBox - 3 replaced
  • mdiCalendar - 3 replaced
  • mdiDelete - 3 replaced
  • mdiToyBrickPlus - 3 replaced
  • mdiToyBrick - 3 replaced
  • mdiPlayCircle - 3 replaced
  • mdiTooltip - 3 replaced
  • mdiAccountGroup - 7 replaced
  • mdiPlay - 3 replaced
  • mdiOfficeBuilding - 2 replaced
  • mdiClipboard - 2 replaced
  • mdiLock - 4 replaced

@skjnldsv skjnldsv requested a review from a team as a code owner July 23, 2025 10:06
@skjnldsv skjnldsv requested review from nfebe, sorbaugh and susnux and removed request for a team July 23, 2025 10:06
@skjnldsv skjnldsv self-assigned this Jul 23, 2025
@skjnldsv skjnldsv added design Design, UI, UX, etc. 2. developing Work in progress enhancement labels Jul 23, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jul 23, 2025
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jul 23, 2025
@github-project-automation github-project-automation bot moved this to In progress in Files to vue Jul 23, 2025
@skjnldsv skjnldsv removed this from Files to vue Jul 23, 2025
@github-project-automation github-project-automation bot moved this to 🏗️ In progress in 📁 Files team Jul 23, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats best to review? Only review changed ones or also missing?
Nevertheless there are some that must not be outlined here

@skjnldsv
Copy link
Member Author

Thanks for the extensive review!
This was done by a script, and while some were supposed to be ignored, it seems they weren't 🙈

I'll do a second pass with adjustments 👍

@skjnldsv skjnldsv force-pushed the feat/vue-material-icons-outline branch 2 times, most recently from e03207f to 5e95fa3 Compare July 23, 2025 11:54
@skjnldsv skjnldsv requested a review from susnux July 23, 2025 11:54
@skjnldsv
Copy link
Member Author

Whats best to review? Only review changed ones or also missing?

I think most should have been caught by the script.
We can adjust as time goes when we encounter icons in the future I think

Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

current icons seem to be fine ✅

@skjnldsv
Copy link
Member Author

@skjnldsv if you have some screenshots for review let us know :) I see folder-outline for example – just make sure that for the filetype icons, the icons are still filled as per the "Exceptions" in #53701

Will be pretty hard to make screenshots of it all.
You'll have to trust the process and catch them as we go. We can't really screenshots all of those changes

@skjnldsv skjnldsv force-pushed the feat/vue-material-icons-outline branch from 8a4b92b to dc1ac8d Compare July 24, 2025 07:57
@skjnldsv skjnldsv requested a review from jancborchardt July 24, 2025 08:08
@skjnldsv skjnldsv force-pushed the feat/vue-material-icons-outline branch from dc1ac8d to 3c07ab8 Compare July 24, 2025 08:10
@skjnldsv skjnldsv requested a review from a team as a code owner July 24, 2025 08:27
@jancborchardt
Copy link
Member

@skjnldsv sounds good! :)

@skjnldsv skjnldsv force-pushed the feat/vue-material-icons-outline branch from 0137f21 to 8defefe Compare July 24, 2025 08:57
@skjnldsv
Copy link
Member Author

Okay, did another pass.
There was some issue with the MDI js script.

I specifically forced the outline on

  • FolderMultiple
  • FileUpload

And made sure we keep any filled

  • Folder*
  • File*
  • Download*

@skjnldsv
Copy link
Member Author

2025-07-24_10-59

Files

@skjnldsv skjnldsv enabled auto-merge July 24, 2025 09:41
Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

@skjnldsv skjnldsv merged commit 5fa71ab into master Jul 24, 2025
132 of 136 checks passed
@skjnldsv skjnldsv deleted the feat/vue-material-icons-outline branch July 24, 2025 09:42
@skjnldsv skjnldsv moved this from 🏗️ In progress to ☑️ Done in 📁 Files team Aug 11, 2025
kra-mo added a commit that referenced this pull request Aug 14, 2025
kra-mo added a commit that referenced this pull request Aug 14, 2025
kra-mo added a commit that referenced this pull request Aug 14, 2025
susnux pushed a commit that referenced this pull request Aug 15, 2025
skjnldsv pushed a commit that referenced this pull request Aug 18, 2025
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Projects

Status: ☑️ Done

Development

Successfully merging this pull request may close these issues.

5 participants