Skip to content

Conversation

@kra-mo
Copy link
Member

@kra-mo kra-mo commented Aug 14, 2025

Follow-up to #54054

For the folder icons, I suppose we should have been clearer that retaining the filled variant only applies to the main view, not menus, sidebars, etc.

Checklist

Before After
image image

@kra-mo kra-mo requested review from a team and skjnldsv as code owners August 14, 2025 11:21
@kra-mo kra-mo requested review from susnux and szaimen and removed request for a team August 14, 2025 11:21
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@szaimen szaimen added this to the Nextcloud 32 milestone Aug 14, 2025
@szaimen szaimen added design Design, UI, UX, etc. 3. to review Waiting for reviews labels Aug 14, 2025
@kra-mo kra-mo force-pushed the fix/outline-extra-icons branch from 109a3e7 to 657e9ca Compare August 14, 2025 11:30
@kra-mo
Copy link
Member Author

kra-mo commented Aug 15, 2025

We detected that the Electron Renderer process just crashed.

We have failed the current spec but will continue running the next spec.

This can happen for a number of different reasons.

If you're running lots of tests on a memory intense application.

  • Try increasing the CPU/memory on the machine you're running on.
  • Try enabling experimentalMemoryManagement in your config file.
  • Try lowering numTestsKeptInMemory in your config file during 'cypress open'.

You can learn more here:

https://on.cypress.io/renderer-process-crashed

I'm guessing this is not my fault by increasing the memory footprint of the SVG 1000x or something? :D

@susnux susnux force-pushed the fix/outline-extra-icons branch from 657e9ca to 114b823 Compare August 15, 2025 08:15
@susnux
Copy link
Contributor

susnux commented Aug 15, 2025

/compile

@nextcloud-command nextcloud-command requested a review from a team as a code owner August 15, 2025 08:23
kra-mo and others added 2 commits August 18, 2025 10:03
@skjnldsv skjnldsv force-pushed the fix/outline-extra-icons branch from 2bed9ca to 01273b3 Compare August 18, 2025 08:03
@AndyScherzinger AndyScherzinger merged commit f824a59 into master Aug 18, 2025
134 of 136 checks passed
@AndyScherzinger AndyScherzinger deleted the fix/outline-extra-icons branch August 18, 2025 22:19
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants