Skip to content

Conversation

@st3iny
Copy link
Member

@st3iny st3iny commented Jul 30, 2025

Summary

The ICreateFromString API does not send invitation emails currently. This should be considered a bug. However, we can't backport this fix as some of the consumers actually rely on this broken behavior, for example, Calendar appointments.

Hence, I fixed the createFromString() method and created a new one createFromStringMinimal() to keep the old behavior.

Checklist

@st3iny st3iny added this to the Nextcloud 32 milestone Jul 30, 2025
@st3iny st3iny requested a review from miaulalala July 30, 2025 14:11
@st3iny st3iny self-assigned this Jul 30, 2025
@st3iny st3iny requested review from a team, SebastianKrupinski and tcitworld as code owners July 30, 2025 14:11
@st3iny st3iny requested review from ArtificialOwl and removed request for a team July 30, 2025 14:11
@st3iny st3iny added the 3. to review Waiting for reviews label Jul 30, 2025
@st3iny st3iny requested review from come-nc and salmart-dev July 30, 2025 14:11
@st3iny st3iny added the feature: caldav Related to CalDAV internals label Jul 30, 2025
@st3iny st3iny force-pushed the feat/event-builder-invitation-emails branch from 8d7b091 to b1a106c Compare July 30, 2025 14:12
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@st3iny st3iny force-pushed the feat/event-builder-invitation-emails branch from 8bae652 to d6d94c4 Compare July 30, 2025 16:54
@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jul 30, 2025
@st3iny st3iny enabled auto-merge July 30, 2025 16:54
@st3iny st3iny merged commit 46cf819 into master Jul 31, 2025
215 of 220 checks passed
@st3iny st3iny deleted the feat/event-builder-invitation-emails branch July 31, 2025 07:10
@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug enhancement feature: caldav Related to CalDAV internals

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Events created through ICalendarEventBuilder do not trigger invitation emails

5 participants