fix: Calendar invitation emails for Events created from Talk #15575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miaulalala
added
bug
feature: api 🛠️
Contributor
Author
|
/backport to stable31 |
miaulalala
changed the title
miaulalala
force-pushed
the
fix/14698/invitation-emails-from-talk
branch
from
54b329d to
70d69c7
Compare
Signed-off-by: Anna Larch <[email protected]>
miaulalala
force-pushed
the
fix/14698/invitation-emails-from-talk
branch
from
4580bd4 to
6a11249
Compare
| return new DataResponse(['error' => 'calendar'], Http::STATUS_BAD_REQUEST); | ||
| } | ||
|
|
||
| $this->authTokenProvider->invalidateToken($token); |
Member
There was a problem hiding this comment.
this needs to be in a finally block or also inside the catch?
Should we add a sanity background job to clear those up?
Contributor
Author
There was a problem hiding this comment.
Good point, I think a finally will work.
miaulalala
commented
Aug 5, 2025
| } catch (\InvalidArgumentException|CalendarException $e) { | ||
| $client->put($calendarUri, $options); | ||
| } catch (\Exception $e) { | ||
| $this->logger->debug('Failed to get calendar to schedule a meeting', ['exception' => $e]); |
Contributor
Author
There was a problem hiding this comment.
Suggested change
| $this->logger->debug('Failed to get calendar to schedule a meeting', ['exception' => $e]); | |
| $this->logger->error('Failed to get calendar to schedule a meeting', ['exception' => $e]); |
Contributor
Author
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14698
🛠️ API Checklist
🏁 Checklist
docs/has been updated or is not required