-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(AppMenu): add slight opactiy gradient to app icons #54178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
kra-mo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, definitely more noticeable with more than 2 icons :)
|
Oh and also… would this affect the right-side items like notifications and search? It would be nice if it did. |
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM based on the screenshot. Do we know if this effects performance negatively?
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful!!
So glad mask is finally property supported globally
For 5-15 apps, I would be surprised if that would have a noticeable impact. But I'd be curious to be proven otherwise 🤔 |
b19e1d0 to
012320b
Compare
I have slightly adjust the way it works, by defining a variable for it, this way we can do this in the library. Also fixed it for the high contrast theme. |
- resolves #54141 Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
012320b to
4e4c4d1
Compare
Allowing to have the new styles from #54178 and nextcloud-libraries/nextcloud-vue#7242 Signed-off-by: Ferdinand Thiessen <[email protected]>
Allowing to have the new styles from #54178 and nextcloud-libraries/nextcloud-vue#7242 Signed-off-by: Ferdinand Thiessen <[email protected]>
jancborchardt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@susnux @kra-mo so @AndyScherzinger and I just checked this out and we were wondering if we can go a bit lower than 75% opacity? Cause right now it is very nice, but indeed barely visible if you don’t know about it.
Yeah, I mentioned that I think 65 could work and might be nice. |
This comment was marked as resolved.
This comment was marked as resolved.
|
Guess I misunderstood, see #54418 :) |
Summary
Now its a gradient from 100% opacity to 75% opacity.
If you think you see no difference, this is if I set from 100% to 40% 😉 :
Checklist