Skip to content

Conversation

@susnux
Copy link
Contributor

@susnux susnux commented Jul 31, 2025

Summary

Now its a gradient from 100% opacity to 75% opacity.

before after
Screenshot 2025-07-31 at 15-38-30 Dashboard - Nextcloud Screenshot 2025-07-31 at 15-38-13 Dashboard - Nextcloud

If you think you see no difference, this is if I set from 100% to 40% 😉 :

Screenshot 2025-07-31 at 15-24-16 Dashboard - Nextcloud

Checklist

@susnux susnux added this to the Nextcloud 32 milestone Jul 31, 2025
@susnux susnux requested review from kra-mo and marcoambrosini July 31, 2025 13:42
@susnux susnux requested a review from a team as a code owner July 31, 2025 13:42
@susnux susnux requested review from nfebe, skjnldsv and sorbaugh and removed request for a team July 31, 2025 13:42
@susnux susnux added enhancement design Design, UI, UX, etc. 3. to review Waiting for reviews 🍂 2025-Autumn labels Jul 31, 2025
@susnux susnux requested review from szaimen and removed request for sorbaugh July 31, 2025 13:43
Copy link
Member

@kra-mo kra-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, definitely more noticeable with more than 2 icons :)

@kra-mo
Copy link
Member

kra-mo commented Jul 31, 2025

Although now looking at it, it seems like even 65% meets AA contrast levels with our default theme (even though before it looked like it didn't, color spaces are weird), maybe we could try that? That is what I originally got when playing around with the values.

image

@kra-mo
Copy link
Member

kra-mo commented Jul 31, 2025

Oh and also… would this affect the right-side items like notifications and search? It would be nice if it did.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the screenshot. Do we know if this effects performance negatively?

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful!!
So glad mask is finally property supported globally

@skjnldsv
Copy link
Member

LGTM based on the screenshot. Do we know if this effects performance negatively?

For 5-15 apps, I would be surprised if that would have a noticeable impact. But I'd be curious to be proven otherwise 🤔

@susnux susnux force-pushed the feat/app-icon-opacity branch 2 times, most recently from b19e1d0 to 012320b Compare July 31, 2025 16:23
@susnux susnux requested a review from a team as a code owner July 31, 2025 16:23
@susnux susnux requested review from icewind1991 and leftybournes and removed request for a team July 31, 2025 16:23
@susnux
Copy link
Contributor Author

susnux commented Jul 31, 2025

Oh and also… would this affect the right-side items like notifications and search? It would be nice if it did.

I have slightly adjust the way it works, by defining a variable for it, this way we can do this in the library.
Then all apps automatically should have the mask applied, see nextcloud-libraries/nextcloud-vue#7242

Also fixed it for the high contrast theme.

@susnux susnux force-pushed the feat/app-icon-opacity branch from 012320b to 4e4c4d1 Compare July 31, 2025 17:02
@susnux susnux requested a review from a team as a code owner July 31, 2025 17:02
susnux added a commit that referenced this pull request Jul 31, 2025
@susnux susnux merged commit ba3e5ad into master Jul 31, 2025
216 of 221 checks passed
@susnux susnux deleted the feat/app-icon-opacity branch July 31, 2025 19:00
nextcloud-command pushed a commit that referenced this pull request Aug 6, 2025
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@susnux @kra-mo so @AndyScherzinger and I just checked this out and we were wondering if we can go a bit lower than 75% opacity? Cause right now it is very nice, but indeed barely visible if you don’t know about it.

@kra-mo
Copy link
Member

kra-mo commented Aug 14, 2025

@susnux @kra-mo so @AndyScherzinger and I just checked this out and we were wondering if we can go a bit lower than 75% opacity? Cause right now it is very nice, but indeed barely visible if you don’t know about it.

Yeah, I mentioned that I think 65 could work and might be nice.

@skjnldsv

This comment was marked as resolved.

@skjnldsv
Copy link
Member

Guess I misunderstood, see #54418 :)

@skjnldsv skjnldsv mentioned this pull request Aug 19, 2025
@skjnldsv skjnldsv modified the milestones: Nextcloud 32, Nextcloud 33 Sep 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. enhancement 🍂 2025-Autumn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a slight opacity gradient to app icons

6 participants