feat: create guests through the contacts menu #54330
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leftybournes
requested review from
nfebe,
skjnldsv and
susnux
and removed request for
a team
skjnldsv
reviewed
Aug 12, 2025
core/src/views/ContactsMenu.vue
Outdated
Comment on lines
189
to
191
| if (OCA.Guests && OCA.Guests.openGuestDialog) { | ||
| this.$refs.contactsmenu.closeMenu() | ||
| OCA.Guests.openGuestDialog('core') | ||
| } |
Member
There was a problem hiding this comment.
Suggested change
| if (OCA.Guests && OCA.Guests.openGuestDialog) { | |
| this.$refs.contactsmenu.closeMenu() | |
| OCA.Guests.openGuestDialog('core') | |
| } | |
| if (window?.OCA?.Guests?.openGuestDialog) { | |
| this.$refs.contactsmenu.closeMenu() | |
| OCA.Guests.openGuestDialog('core') | |
| } |
Contributor
There was a problem hiding this comment.
I would also prefer a small (not public) API here the other way around to allow adding a button.
And put the registration into guests app.
Because having external apps references in server feels the wrong way.
Contributor
Author
There was a problem hiding this comment.
Same with what we're doing for files sharing here? https://github.com/nextcloud/guests/blob/main/src/main.js#L54
Contributor
Author
There was a problem hiding this comment.
Done here: #54474 and nextcloud/guests#1380
We can just close this PR if the above ones are approved and merged.
skjnldsv
reviewed
Aug 12, 2025
skjnldsv
reviewed
Aug 12, 2025
Signed-off-by: Kent Delante <[email protected]>
leftybournes
force-pushed
the
leftybournes/feat/guests_creation_simplification
branch
from
f64f0e0 to
f41652b
Compare
Contributor
Author
|
Closing this in favor of: |
leftybournes
deleted the
leftybournes/feat/guests_creation_simplification
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Guests are currently created through file shares and this simplifies creation by allowing users to invite guests through the contacts menu on the top right.
Before:
After:
Checklist