fix(ZipFolderPlugin): set mtime of directories in archive #54401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Directories should also have the correct mtime set and not the current time. For this the `Streamer` class needs to support passing a time attribute for creating folders, the underlying library already supports this. Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
requested review from
Altahrim,
CarlSchwan,
icewind1991 and
salmart-dev
and removed request for
a team
Contributor
Author
|
/backport to stable31 |
5 tasks
salmart-dev
approved these changes
Aug 13, 2025
joshtrichards
added
the
hotspot: file time handling
nfebe
approved these changes
Aug 13, 2025
CarlSchwan
approved these changes
Aug 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Directories should also have the correct mtime set and not the current time. For this the
Streamerclass needs to support passing a time attribute for creating folders, the underlying library already supports this.Checklist