fix(Streamer): use localtime for ZIP files #54402
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshtrichards
added
the
hotspot: file time handling
susnux
requested review from
come-nc,
icewind1991 and
sorbaugh
and removed request for
a team
susnux
force-pushed
the
fix/streamer-mtime-zip
branch
from
0b489d8 to
7428b5b
Compare
Contributor
Author
|
/backport to stable31 |
icewind1991
reviewed
Aug 13, 2025
AndyScherzinger
approved these changes
Aug 13, 2025
susnux
force-pushed
the
fix/streamer-mtime-zip
branch
from
7428b5b to
6f0e0de
Compare
icewind1991
approved these changes
Aug 14, 2025
ZIP does not use a proper timestamp but uses something called "DOS time". This is a weird old format with some limitations like accuracy of only 2 seconds, but also no timezone information. Also unline UNIX time it is not relative to some specific point in time with timezone information, but is always considered to be the local time. Meaning we need to convert it first to the users local time. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/streamer-mtime-zip
branch
from
6f0e0de to
ba00416
Compare
come-nc
reviewed
Aug 14, 2025
Contributor
come-nc
left a comment
come-nc
left a comment
There was a problem hiding this comment.
That means users A and B downloading the same zip content will get different time information in there? So if I download stuff and then send it to someone on another time zone times will look wrong on their computer?
Contributor
Author
Yes and there is no fix - ZIP time is considered the local time of the user that created it. |
come-nc
approved these changes
Aug 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ZIP does not use a proper timestamp but uses something called "DOS time".
This is a weird old format with some limitations like accuracy of only
2 seconds, but also no timezone information.
Also unlike UNIX time it is not relative to some specific point in time
with timezone information, but is always considered to be the local
time. Meaning we need to convert it first to the users local time.
Checklist