feat(teams): Register new vue-based teams widget #54467
Conversation
Signed-off-by: nfebe <[email protected]>
|
|
||
| module.exports = { | ||
| circles: { | ||
| 'teams-widget': path.join(__dirname, 'apps/circles/js', 'teams-widget.js'), |
There was a problem hiding this comment.
shouldnt this config rather be added to the circles app directly?
There was a problem hiding this comment.
Nextcloud apps can only inject scripts using \OCP\Util::addScript() (I believe), which looks for pre-built JS files in the app's js/ directory or webpack-compiled bundles from the server's build process.
The circles app does not have it's javascript build system.
The only way forward is to move the frontend aspects to the contacts app. See : nextcloud/circles#2085 (review)
However, the circles app initially handled everything so I thought to do it there first and then present the option to move it.
That said, for NC32. I think we can leave it like this and then move it to the contacts app/delete this line in a beta.
There was a problem hiding this comment.
How should this work? The circles app is not available during the build of Nextcloud server.
This must either be moved to circles app (and add the build system there) or the contacts app.
|
Moving to contacts app. |
github-project-automation
bot
moved this from 🏗️ In progress
to ☑️ Done
in 📁 Files team
Resolves : nextcloud/circles#1938
Todo