Skip to content

feat(teams): Register new vue-based teams widget #54467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nfebe wants to merge 1 commit into from
Closed

feat(teams): Register new vue-based teams widget #54467

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions webpack.modules.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
const path = require('path')

module.exports = {
circles: {
'teams-widget': path.join(__dirname, 'apps/circles/js', 'teams-widget.js'),
Copy link
Contributor

@szaimen szaimen Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldnt this config rather be added to the circles app directly?

Copy link
Contributor Author

@nfebe nfebe Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nextcloud apps can only inject scripts using \OCP\Util::addScript() (I believe), which looks for pre-built JS files in the app's js/ directory or webpack-compiled bundles from the server's build process.

The circles app does not have it's javascript build system.

The only way forward is to move the frontend aspects to the contacts app. See : nextcloud/circles#2085 (review)

However, the circles app initially handled everything so I thought to do it there first and then present the option to move it.

That said, for NC32. I think we can leave it like this and then move it to the contacts app/delete this line in a beta.

Copy link
Contributor

@susnux susnux Aug 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How should this work? The circles app is not available during the build of Nextcloud server.
This must either be moved to circles app (and add the build system there) or the contacts app.

},
comments: {
'comments-app': path.join(__dirname, 'apps/comments/src', 'comments-app.js'),
'comments-tab': path.join(__dirname, 'apps/comments/src', 'comments-tab.js'),
Expand Down
Loading