-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
chore: refactor .htaccess to ease maintenance/future cleanup
#54550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Josh <[email protected]>
.htaccess to ease maintenance/future cleanup
solracsf
reviewed
Aug 20, 2025
Signed-off-by: Josh <[email protected]>
kesselb
reviewed
Aug 20, 2025
Contributor
AIO uses Apache under the hood so no manual changes should not be needed. See https://github.com/nextcloud/all-in-one/blob/main/Containers/apache/nextcloud.conf#L31 |
This was referenced Aug 22, 2025
Merged
Merged
Merged
Merged
Merged
Merged
Merged
J0WI
approved these changes
Nov 25, 2025
Signed-off-by: John Molakvoæ <[email protected]>
skjnldsv
approved these changes
Nov 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
3. to review
Waiting for reviews
feature: authentication
feature: dav
♻️ refactor
Refactor code (not a bug fix, not a feature just refactoring)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Despite the size this changes should be a no-op in terms of functionality. Just trying to ease future maintenance burden:
Added:
RewriteRulesinto dedicated sections for ease of maintenanceChanged:
Possible follow-ups:
XXXin the comments) were discovered while doing this refactorhtaccess.rewritebaseshould also be audited and possibly restructured in a similar manner:server/lib/private/Setup.php
Lines 573 to 595 in 93b97f4
TODO
Checklist