fix: add missing sharing options to ui and add full-match results #55311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
requested review from
nfebe and
szaimen
and removed request for
a team
Contributor
Author
|
/backport to stable32 |
Contributor
Author
|
/backport to stable31 |
susnux
force-pushed
the
fix/sharing-results-collaboration
branch
from
81fc78d to
80ae8f5
Compare
Altahrim
approved these changes
Sep 26, 2025
| || ($this->shareeEnumerationFullMatchEmail && strtolower($userEmail ?? '') === $lowerSearch)) | ||
| && $lowerSearch !== '' | ||
| && ( | ||
| strtolower($uid) === $lowerSearch |
Collaborator
There was a problem hiding this comment.
I was wondering if strcasecmp is better but it seems similar :)
Add missing `matchUserId` method for full-match-autocomplete options and update docs to make it clearer what each options exactly means. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
When searching we need to: 1. check if sharing is limited to groups - if yes only include those - otherwise continue 2. check if there are restrictions to groups or phonebook 3. check if full match is included Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
force-pushed
the
fix/sharing-results-collaboration
branch
from
80ae8f5 to
5c7ca58
Compare
Contributor
Author
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
This was referenced Sep 26, 2025
susnux
added
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
For restricting autocompletion of sharing we have various options, some of them got forgotten in the Vue migration.
Those are added back to the ui.
Then added the missing method to the share manager, the email and second user dn methods already existed but the user id one was missing. Also improved the doc blocks to make it clearer what those values mean.
Finally this fixes the user plugin to also include full-matches when group enumeration was enabled.
Checklist
3. to review, feature component)stable32)