-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
[stable32] fix: add missing sharing options to ui and add full-match results #55329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szaimen
approved these changes
Sep 26, 2025
Contributor
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐘
250cb16 to
a3a5f12
Compare
Contributor
|
/compile |
susnux
approved these changes
Oct 1, 2025
a3a5f12 to
54e694d
Compare
Add missing `matchUserId` method for full-match-autocomplete options and update docs to make it clearer what each options exactly means. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
When searching we need to: 1. check if sharing is limited to groups - if yes only include those - otherwise continue 2. check if there are restrictions to groups or phonebook 3. check if full match is included Signed-off-by: Ferdinand Thiessen <[email protected]>
54e694d to
919701c
Compare
Contributor
|
/compile |
Signed-off-by: nextcloud-command <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #55311
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.