Skip to content

Conversation

@backportbot
Copy link

@backportbot backportbot bot commented Oct 2, 2025

Backport of #55486

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

… entry completely

Signed-off-by: Christian Wolf <[email protected]>

[skip ci]
@backportbot backportbot bot added bug 3. to review Waiting for reviews labels Oct 2, 2025
@backportbot backportbot bot added this to the Nextcloud 32.0.1 milestone Oct 2, 2025
@christianlupus christianlupus force-pushed the backport/55486/stable32 branch from 899c120 to a199b64 Compare October 2, 2025 21:40
@christianlupus christianlupus marked this pull request as ready for review October 2, 2025 21:40
@christianlupus christianlupus requested a review from a team as a code owner October 2, 2025 21:40
@christianlupus christianlupus requested review from sorbaugh and removed request for a team October 2, 2025 21:40
Copy link
Contributor

@christianlupus christianlupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it again and had to rebuild (and commit) the changes in the dist folder. With the rebuilt files, I could test the fix and saw no more error.

@newcourse1984
Copy link

Hi, I’m new to GIT. It’s interesting to see how backports differ from the original PR. I’m curious, why was this backport approach chosen instead of applying the fix directly to the stable32 branch?

@christianlupus
Copy link
Contributor

@newcourse1984 and @lyssahenderson, here is the wrong location to discuss this. I created therefore this topic on the forums: https://help.nextcloud.com/t/discussion-about-backporting/233435

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@susnux susnux merged commit 84b4505 into stable32 Oct 3, 2025
130 checks passed
@susnux susnux deleted the backport/55486/stable32 branch October 3, 2025 16:07
@blizzz blizzz mentioned this pull request Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants