-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Allow to remove a website in the user profile #55486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
szaimen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but didnt test
|
I tested on the current master (well yesterday) and it worked in the frontend to add and remove an URL. |
… entry completely Signed-off-by: Christian Wolf <[email protected]>
5b636b8 to
d40e58d
Compare
|
/backport to stable32 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
… entry completely
Summary
The removal of a website in the profile is prevented as the empty string is no valid URL. This circumvents the check if the string is empty.
TODO
Checklist
3. to review, feature component)stable32)