Skip to content

Conversation

@christianlupus
Copy link
Contributor

@christianlupus christianlupus commented Oct 1, 2025

… entry completely

Summary

The removal of a website in the profile is prevented as the empty string is no valid URL. This circumvents the check if the string is empty.

TODO

  • ...

Checklist

@christianlupus christianlupus added bug 2. developing Work in progress labels Oct 1, 2025
@christianlupus christianlupus marked this pull request as ready for review October 2, 2025 09:09
@christianlupus christianlupus requested a review from a team as a code owner October 2, 2025 09:09
@christianlupus christianlupus requested review from nfebe, skjnldsv and szaimen and removed request for a team October 2, 2025 09:09
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 2, 2025
@szaimen szaimen added this to the Nextcloud 33 milestone Oct 2, 2025
@christianlupus
Copy link
Contributor Author

I tested on the current master (well yesterday) and it worked in the frontend to add and remove an URL.

@christianlupus christianlupus force-pushed the fix/55003-allow-empty-mail-address branch from 5b636b8 to d40e58d Compare October 2, 2025 12:21
@susnux susnux merged commit 2ea0568 into master Oct 2, 2025
150 of 154 checks passed
@susnux susnux deleted the fix/55003-allow-empty-mail-address branch October 2, 2025 18:51
@susnux
Copy link
Contributor

susnux commented Oct 2, 2025

/backport to stable32

@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Contents of the "Website" field under "Personal settings" -> "Personlal info" cannot be deleted.

4 participants